BUG: GetBlockFormatNames Method Memory Leak in Afxhtml.h (315482)

RESOLUTION

• Change the GetBlockFormatNames method in the Afxhtml.h header file to free the BSTR variable bstrElem after the method accesses the variable. Call SafeArrayDestroy to release SAFEARRAY *psa.
  
  -or-
• Do not call the GetBlockFormatNames method. Instead, copy and paste the following sample code into your code. The sample code frees the BSTR variable bstrElem after the method accesses the variable, and then calls SafeArrayDestroy to release SAFEARRAY *psa.

HRESULT GetBlockFormatNames(CStringArray &sa) const
{
    CComVariant vaRet;
    HRESULT hr = E_FAIL;
    long lStatus = QueryStatus(IDM_GETBLOCKFMTS);
    if (lStatus & OLECMDF_ENABLED || lStatus & OLECMDF_LATCHED)
    {
        if (S_OK == ExecCommand(IDM_GETBLOCKFMTS, OLECMDEXECOPT_DODEFAULT, NULL, &vaRet))
        {						 
            if(vaRet.vt & VT_ARRAY)
            {
                 USES_CONVERSION;
                 SAFEARRAY *psa = vaRet.parray;
				
                 long lBound = 0,uBound = 0;
                 if(S_OK == SafeArrayGetLBound(psa,1,&lBound) &&
                     S_OK == SafeArrayGetUBound(psa,1,&uBound) )
                 {
                     for(long i=lBound; i<uBound; i++)
                     {	
                         CComBSTR bstrElem;
                         if( (S_OK == SafeArrayGetElement(psa, &i, &bstrElem)) )
                             sa.Add(CString(OLE2T(bstrElem)));
                     }
                     SafeArrayDestroy(psa); 		//Release psa.

                     hr = S_OK;
                 }
            }
        }
    }

    if (vaRet.vt == VT_ERROR) {
        hr = V_ERROR(&vaRet);
    }

    return hr;
}